Bug 28136

Summary: [PATCH] add EVMS specific devmapper name mangling to whitelist
Product: Sisyphus Reporter: Michael Shigorin <mike>
Component: libdevmapperAssignee: Michael Shigorin <mike>
Status: CLOSED NOTABUG QA Contact: qa-sisyphus
Severity: normal    
Priority: P3 CC: aen, rider, shaba, timonbl4, vitty
Version: unstable   
Hardware: all   
OS: Linux   
Bug Depends on:    
Bug Blocks: 28020    
Attachments:
Description Flags
a quick&dirty patch to allow '|' in devmapper device node names none

Description Michael Shigorin 2012-11-27 19:04:43 MSK
Created attachment 5656 [details]
a quick&dirty patch to allow '|' in devmapper device node names

This patch extends _is_whitelisted_char() with an EVMS specific "|" since e.g. lvm2 plugin would result in node names like "/dev/mapper/lvm2|$vg|$lv" and libdevmapper wouldn't let these through complaining that, e.g.,
> The name "lvm2|main|root" should be mangled but it contains blacklisted characters.

It was proposed upstream on the official #device-mapper freenode channel, so far found debatable due to the potential security implications of the pipe character in faulty scripts given the possibility of coercing an unsuspecting [EVMS] user to insert a rogue usbflash but otherwise not turned down unequivocally; will submit to an upstream ML as suggested by asalor.

I can prepare a proper NMU with this patch in alt/ if you don't mind; in the mean time will work with upstream to get it there as a legacy compatibility option.
Comment 2 AEN 2012-12-02 10:30:31 MSK
А у нас-то чего его не приложить, если нужен?
Comment 3 Michael Shigorin 2012-12-02 22:27:54 MSK
Потому и повесил на себя, но не закрываю, что ещё в процессе выяснения.
Если с деактивацией EVMS получится, так и не нужен.
Comment 4 Michael Shigorin 2012-12-04 22:05:21 MSK
См. bug #28181.